Add an API entry-point to the deployWorkspaceProject command#578
Add an API entry-point to the deployWorkspaceProject command#578MicroFish91 merged 52 commits intomainfrom
deployWorkspaceProject command#578Conversation
e4c4296 to
3617d8e
Compare
21b1fd8 to
5aaa76e
Compare
…inerapps into mwf/deploy-workspace-project-api
a4cf584 to
7d2d52f
Compare
7d2d52f to
1fd1c21
Compare
|
Hey all, this should be ready for review again! @nturinski Thanks for all the great feedback, I was able to take a step back and change up the implementation quite a bit in the spirit of your review. I took your recommendation to decouple For removing api references from the internal implementation - I exposed any related surfaces via toggle-able I also consolidated all output logs into the internal implementation to ensure uniform behavior regardless of entry-point. I took your recommendation and removed the references to PR Breakdown Added precursor PR covering the decoupling for the new internal implementation to reduce the amount of code to review in one sitting: I also have these two open PRs which will reduce the length of this PR by a few lines once merged: Here's the setup PR in Functions to consume this API: |
| // Let each client decide how it wants to show its own activity log updates. | ||
| suppressActivity: true, | ||
| suppressConfirmation, | ||
| suppressContainerAppCreation, |
There was a problem hiding this comment.
Let me know if you think it would be a good idea to default some of these values
There was a problem hiding this comment.
Does this comment still make sense? A lot of this seems defaulted already.
53a8267 to
17dd935
Compare
…e-azurecontainerapps into mwf/deploy-workspace-project-api
…e-azurecontainerapps into mwf/deploy-workspace-project-api
| // Let each client decide how it wants to show its own activity log updates. | ||
| suppressActivity: true, | ||
| suppressConfirmation, | ||
| suppressContainerAppCreation, |
There was a problem hiding this comment.
Does this comment still make sense? A lot of this seems defaulted already.
| return createApiProvider([<api.AzureContainerAppsExtensionApi>{ | ||
| apiVersion: '0.0.1', | ||
|
|
||
| deployWorkspaceProject: async (options: api.DeployWorkspaceProjectOptionsContract) => await callWithTelemetryAndErrorHandling('containerApps.api.deployWorkspaceProject', async (context: IActionContext) => { |
There was a problem hiding this comment.
nit: I prefer that we keep the apiProvider looking clean like so:
deployWorkspaceProject: deployWorkspaceProjectApi
And then in deployWorkspaceProjectApi, wrap that whole command with callWithTelemetryAndErrorHandling
88d846d to
e0d9e70
Compare
Closes #571
Will be leveraged by the Azure Functions extension.