Decouple workspace and tree item settings from deployWorkspaceProjectInternal#615
Decouple workspace and tree item settings from deployWorkspaceProjectInternal#615MicroFish91 merged 6 commits intomainfrom
deployWorkspaceProjectInternal#615Conversation
| import { deployWorkspaceProjectInternal, type DeployWorkspaceProjectInternalContext } from "./internal/deployWorkspaceProjectInternal"; | ||
|
|
||
| export async function deployWorkspaceProject(context: IActionContext & Partial<DeployWorkspaceProjectContext>, item?: ContainerAppItem | ManagedEnvironmentItem): Promise<DeployWorkspaceProjectResults> { | ||
| const subscription: AzureSubscription = await subscriptionExperience(context, ext.rgApiV2.resources.azureResourceTreeDataProvider); |
There was a problem hiding this comment.
Any reason for moving this?
If we have an item, we can get the subscription information from that, so I feel like it should probably be below that check still. Granted, it doesn't look like we were doing that before, but we probably should have been.
There was a problem hiding this comment.
Oh that's a good point, I'll move it back below. And we can consider grabbing the subscription if an item is passed in for the V2 iteration
| dwpSettingUtilsV1.displayDeployWorkspaceProjectSettingsOutput(settings); | ||
| } | ||
| // Logic to display local workspace settings related outputs | ||
| if (triggerSettingsOverride(settings, item)) { |
There was a problem hiding this comment.
Do we still need this logic? I'm assuming that we won't ever overwrite workspace deployment settings anymore.
There was a problem hiding this comment.
Not really, but I'm keeping it here because it's necessary to make V1 work which is what is still hooked up until we finish V2 and swap it over :)
2 participants
Closes #610
deployWorkspaceProjectInternalignoreExistingDeploySettings,suppressProgress.