Skip to content

Use existing env variables when updating container app if "skipped"#627

Merged
nturinski merged 1 commit intomainfrom
nat/envVar
Mar 18, 2024
Merged

Use existing env variables when updating container app if "skipped"#627
nturinski merged 1 commit intomainfrom
nat/envVar

Conversation

@nturinski
Copy link
Copy Markdown
Member

@nturinski nturinski commented Mar 18, 2024

Fixes #451

Note that this only applies for updateContainerApp since deployWorkspace leverages getDefaultContextValue which sets context.environmentVariables to [ ] if it doesn't detect an .env file.

I didn't change this behavior because I figured that we will be altering deployWorkspace's behavior; specifically we'll be looking at an envPath setting.

@nturinski nturinski requested a review from a team as a code owner March 18, 2024 17:41
Comment thread src/commands/image/imageSource/EnvironmentVariablesListStep.ts
@nturinski nturinski merged commit 690fe13 into main Mar 18, 2024
@nturinski nturinski deleted the nat/envVar branch March 18, 2024 21:40
@MicroFish91 MicroFish91 added this to the 0.7.0 milestone Mar 19, 2024
@microsoft microsoft locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow option to carry-over existing environment variables

2 participants