Merged
Conversation
…-azurecontainerapps into mwf/dwp-starting-config-1
…oft/vscode-azurecontainerapps into mwf/add-missing-resources
…econtainerapps into mwf/man-env-list-step
…azurecontainerapps into mwf/default-resources-ref
…econtainerapps into mwf/man-env-list-step
…azurecontainerapps into mwf/default-resources-ref
Contributor
Author
|
@nturinski Double check this one please |
nturinski
reviewed
Mar 25, 2024
| !context.registry && (context.newRegistryName = await RegistryNameStep.tryGenerateRelatedName(context, workspaceName)); | ||
| !context.containerApp && (context.newContainerAppName = workspaceName); | ||
| context.imageName = ImageNameStep.getTimestampedImageName(context.containerApp?.name || workspaceName); | ||
| !context.resourceGroup && (context.newResourceGroupName = resourceName); |
Member
There was a problem hiding this comment.
I still suggest we should add a suffix for each resource type.
resourceName-rg
resourceName-me or resourceName-env
resourceName-app or resourceName-aca
I think when you see them all in the resource group, it makes it a lot easier to distinguish what each resource is. I notice other tooling will do that as well.
Contributor
Author
There was a problem hiding this comment.
I like that idea, let me do that in a separate PR after we discuss what that convention should look like
nturinski
approved these changes
Mar 25, 2024
Member
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
Rest looks good to me. So fresh, so clean
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #611
Closes #603
validateInput(now static methods)