Separate name steps for shared resources and app resources#668
Merged
MicroFish91 merged 10 commits intomainfrom Apr 4, 2024
Merged
Separate name steps for shared resources and app resources#668MicroFish91 merged 10 commits intomainfrom
MicroFish91 merged 10 commits intomainfrom
Conversation
nturinski
approved these changes
Apr 4, 2024
|
|
||
| ext.outputChannel.appendLog( | ||
| !context.resourceGroup || !context.managedEnvironment ? | ||
| localize('usingEnvironmentName', 'User provided the name "{0}" for the new container app environment.', resourceName) : |
Member
There was a problem hiding this comment.
I feel like this is a weird output log message that kind of crowds it. This was an action taken by the user-- this feels like an internal logging message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always prompt separately now if user chooses to create a managed environment. This way, the environment isn't named identically to the first app.