-
Notifications
You must be signed in to change notification settings - Fork 17
Add Edit Container... command
#769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
f63575d
dacb997
a48d28e
6d4b27d
a44d66b
c01e40e
a903c85
ad9cf81
1d1293f
2976650
833c32d
d135da0
513470b
7f57e2c
14cfb97
f5ba71b
3db528e
a391d9b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: the command is named "update container" while the context is the reverse, "container update context". If there's not a good reason for this, then I'd prefer if they matched.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I'm bouncing this one to @nturinski 🤭 I think he asked in a previous meeting people's preferences and was trying to improve naming conventions... but I can't remember who all was there to chime in
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, yeah. I believe the conversation was basically anything that is a class/context should be noun (in this case, Container) prefixed so that in an alphabetical list, it's easy to see all of the Container related files grouped together. However, since commands have been following the "verbNoun" format, I was fine with the reverse order specifically for commands. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import { type ExecuteActivityContext } from "@microsoft/vscode-azext-utils"; | ||
| import { type SetTelemetryProps } from "../../telemetry/SetTelemetryProps"; | ||
| import { type ContainerUpdateTelemetryProps as TelemetryProps } from "../../telemetry/commandTelemetryProps"; | ||
| import { type IContainerAppContext } from "../IContainerAppContext"; | ||
| import { type ImageSourceBaseContext } from "../image/imageSource/ImageSourceContext"; | ||
|
|
||
| export interface ContainerUpdateBaseContext extends IContainerAppContext, ImageSourceBaseContext, ExecuteActivityContext { | ||
| containersIdx: number; | ||
| } | ||
|
|
||
| export type ContainerUpdateContext = ContainerUpdateBaseContext & SetTelemetryProps<TelemetryProps>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to block this PR from merging, but I think we need to discuss the possibility of rewording the command to make it more clear to users what's happening.
We need users to understand that there are pretty much two main actions for container apps:
Nathan and I think that "Update Container..." might be too close to "Edit Container App...". What about using Deploy instead of Update?
Whatever we decide to do, we can make that change after this is merged.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I'll try to squeeze this discussion into one of our next group meetings (probably just the engineers for now). I think these sorts of improvements overlap a ton with my big goal for the next release, and I have some extra context to provide that would be helpful.