Change draft deploy pop-up from an informational window to a quick pick#771
Merged
MicroFish91 merged 6 commits intomainfrom Oct 14, 2024
Merged
Change draft deploy pop-up from an informational window to a quick pick#771MicroFish91 merged 6 commits intomainfrom
MicroFish91 merged 6 commits intomainfrom
Conversation
MicroFish91
changed the title
| "containerApps.revealResource": "Reveal Resource", | ||
| "containerApps.description": "An Azure Container Apps extension for Visual Studio Code.", | ||
| "containerApps.enableOutputTimestamps": "Prepends each line displayed in the output channel with a timestamp.", | ||
| "containerApps.showDraftCommandDeployPopup": "Show an informational deploy pop-up message whenever a draft command is run.", |
Member
There was a problem hiding this comment.
is this enabled by default?
Contributor
Author
There was a problem hiding this comment.
Yeah, it's true by default
Comment on lines
+14
to
+17
| if (!await settingUtils.getGlobalSetting(showDraftCommandDeployPopupSetting)) { | ||
| context.shouldDeployRevisionDraft = false; | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Should you try to move this into shouldPrompt? To do so, you could set this context before running the wizard.
Contributor
Author
There was a problem hiding this comment.
Yeah, nice, good call
MicroFish91
force-pushed
the
mwf/revision-deploy-step
branch
from
84dcf1f to
9a84f73
Compare
alexweininger
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed this with Nathan a while back, and we agreed it would probably be better to use a quick pick instead of a pop-up window after each command. This means the prompt to deploy becomes something we ask at the start rather than something we ask after the draft command finishes.
I'm proposing the process now would be - each draft command should push in the following quick pick step as the last prompt:
new RevisionDraftDeployPromptStep()Almost no 'new' logic has actually been added here, mostly prompt logic from the old
RevisionDraftUpdateBaseStepgot moved into the newRevisionDraftDeployPromptStep.Before (informational window):
After (prompt quick pick):
To see in action, you can test with this command:
Edit: I forgot, I also snuck in a small fix for this...
Fixes #683