Don't show ingress prompts in draft mode and add additional activity children to core draft commands#814
Conversation
MicroFish91
force-pushed
the
mwf/obliged-gold
branch
from
d4e2b15 to
eff6574
Compare
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
Logically it makes sense to me. My comments are suggestions, but I'm not going to try to require it.
| }; | ||
| wizardContext.telemetry.properties.revisionMode = containerApp.revisionsMode; | ||
|
|
||
| if (isAzdExtensionInstalled()) { |
There was a problem hiding this comment.
Why is this being added here? Doesn't seem to be related to the PR?
There was a problem hiding this comment.
Yeah not crucial to this PR at all, but it was small enough that I snuck it in. It was in the same snippet as the output logs code section
| ); | ||
|
|
||
| // Log resource group | ||
| wizardContext.activityChildren?.push( |
There was a problem hiding this comment.
I feel like it might be time to make a utility function to just generate all of this boilerplate for you.
If not a util function, maybe include adding these activity children when you call pickContainerApp or pickManagedEnvironment? Since that seems to be where you are setting all of the wizard's contexts.
I feel like just adding them into the prompt steps themselves would be the best way to do it, but since these are top-level Azure resources, that might not be possible?
There was a problem hiding this comment.
Oh interesting, I hadn't thought about doing it that way, but that might be a clean way to handle this boilerplate. I'll investigate that as a potential solution.
There was a problem hiding this comment.
I consolidated most of the boilerplate under a new starting resource log step, let me know if you like that implementation or think it should be encapsulated differently!
MicroFish91
force-pushed
the
mwf/obliged-gold
branch
from
519424d to
eed858e
Compare
MicroFish91
force-pushed
the
mwf/obliged-gold
branch
from
eed858e to
06e1720
Compare
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
Definitely less concerned about StartingResourcesLogStep since it's always set to false for shouldPrompt 👍
2 participants
Partially addresses part 2 of #719
Examples:
Edit container (edit w/ container registry image):
Edit container image (edit w/ workspace project image):
