Add deployImage as part of API export, add additional activity children, and allow more flexible deployment targets#817
Merged
MicroFish91 merged 46 commits intomainfrom Jan 10, 2025
Merged
Conversation
MicroFish91
changed the title
deployImageApi to list of command exports and add updated activity childrendeployImageApi to list of api exports and add updated activity children
MicroFish91
changed the title
deployImageApi to list of api exports and add updated activity childrendeployImageApi to api export and add updated activity children
MicroFish91
changed the title
deployImageApi to api export and add updated activity childrendeployImageApi as part of API export and add updated activity children
MicroFish91
changed the title
deployImageApi as part of API export and add updated activity childrendeployImageApi to API export, add additional activity children, and allow more flexible deployment targets
MicroFish91
changed the title
deployImageApi to API export, add additional activity children, and allow more flexible deployment targetsdeployImage as part of API export, add additional activity children, and allow more flexible deployment targets by template
MicroFish91
changed the title
deployImage as part of API export, add additional activity children, and allow more flexible deployment targets by templatedeployImage as part of API export, add additional activity children, and allow more flexible deployment targets
MicroFish91
commented
Dec 31, 2024
| } | ||
|
|
||
| // The interface of the command options passed to the Azure Container Apps extension's deployImageToAca command | ||
| // This interface is shared with the Docker extension (https://github.com/microsoft/vscode-docker) |
Contributor
Author
There was a problem hiding this comment.
Carryover of existing interface, but moved into the api type definition
| import { type ContainerRegistryImageSourceContext } from "../image/imageSource/containerRegistry/ContainerRegistryImageSourceContext"; | ||
| import { type DeployImageContext } from "./DeployImageContext"; | ||
|
|
||
| export async function deployImage(context: IActionContext & Partial<ContainerRegistryImageSourceContext>, node: ContainerItem): Promise<void> { |
Contributor
Author
There was a problem hiding this comment.
New changes:
- Wizard context now includes
containersIdxandtemplatewhich are used to allow targets to each revision's container while in multiple revisions mode - Added activity children for logging the existing resource group and container app to keep formatting similar to the other major commands
MicroFish91
commented
Jan 9, 2025
|
|
||
| export type DeployImageApiContext = ImageSourceBaseContext & ExecuteActivityContext & SetTelemetryProps<TelemetryProps>; | ||
|
|
||
| export async function deployImageApi(deployImageOptions: DeployImageToAcaOptionsContract): Promise<void> { |
Contributor
Author
There was a problem hiding this comment.
This function is all carryover code except with a new callWithTelemetryAndErrorHandling wrapper
nturinski
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #719
Docker extension currently is calling into the command directly, but I wanted to expose the command as part of the extension API, so I reorganized it that way and added a backwards compatibility wrapper to keep everything working the same so Docker doesn't have to update anything.
I also made the command less opinionated by allowing the user to pick revision containers as well, basically allowing the command to deploy to all possible resource targets (instead of assuming the latest single revision mode container apps). This required adding an optional context value for the
Template.I also added two new activity children to the command to better indicate when registry credentials were added to the container app envelope.
Examples:
