Skip to content

Fix missing periods in container app and scaling rule output messages #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MicroFish91 merged 5 commits into from
Oct 30, 2025
Merged

Fix missing periods in container app and scaling rule output messages #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f0955e
Initial plan
Copilot Aug 23, 2025
e1da168
Initial analysis of container app creation success message missing pe…
Copilot Aug 23, 2025
e4161f0
Fix missing periods in container app and scaling rule output messages
Copilot Aug 23, 2025
1ca65d5
Remove @swc/core-linux-x64-gnu package as requested
Copilot Aug 23, 2025
c184307
Revert unwanted changes to package-lock.json, main.js, and gulpfile.ts
Copilot Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/createContainerApp/ContainerAppCreateStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { type ContainerAppCreateContext } from "./ContainerAppCreateContext";
export class ContainerAppCreateStep<T extends ContainerAppCreateContext> extends AzureWizardExecuteStepWithActivityOutput<T> {
public priority: number = 620;
public stepName: string = 'containerAppCreateStep';
protected getOutputLogSuccess = (context: T) => localize('createContainerAppSuccess', 'Created container app "{0}"', context.newContainerAppName);
protected getOutputLogSuccess = (context: T) => localize('createContainerAppSuccess', 'Created container app "{0}".', context.newContainerAppName);
protected getOutputLogFail = (context: T) => localize('createContainerAppFail', 'Failed to create container app "{0}"', context.newContainerAppName);
protected getTreeItemLabel = (context: T) => localize('createContainerAppLabel', 'Create container app "{0}"', context.newContainerAppName);

Expand Down
2 changes: 1 addition & 1 deletion src/commands/scaling/scaleRule/addScaleRule/AddScaleRuleStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export class AddScaleRuleStep<T extends IAddScaleRuleContext> extends RevisionDr
await this.updateRevisionDraftWithTemplate(context);

const resourceName = getParentResourceFromItem(this.baseItem).name;
ext.outputChannel.appendLog(localize('addedScaleRule', 'Added {0} rule "{1}" to "{2}" (draft)', context.newRuleType, context.newRuleName, resourceName));
ext.outputChannel.appendLog(localize('addedScaleRule', 'Added {0} rule "{1}" to "{2}" (draft).', context.newRuleType, context.newRuleName, resourceName));
}

public shouldExecute(context: T): boolean {
Expand Down
2 changes: 1 addition & 1 deletion src/commands/scaling/scaleRule/deleteScaleRule/DeleteScaleRuleStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class DeleteScaleRuleStep<T extends ScaleRuleContext> extends RevisionDra
await this.updateRevisionDraftWithTemplate(context);

const resourceName = getParentResourceFromItem(this.baseItem).name;
ext.outputChannel.appendLog(localize('deletedScaleRule', 'Deleted rule "{0}" from "{1}" (draft)', context.scaleRule?.name, resourceName));
ext.outputChannel.appendLog(localize('deletedScaleRule', 'Deleted rule "{0}" from "{1}" (draft).', context.scaleRule?.name, resourceName));
}

public shouldExecute(context: T): boolean {
Expand Down
⚡