Add Deploy to Container App with Copilot command #965
Conversation
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
Looks great to me.
Just thinking out loud, but I think in the future, all the wrapper code you put into deployContainerApp may be better to make a util function that basically just wraps the command with all of the Copilot trappings. It should make it easier to just apply to all of our commands.
| const confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input may need to change as well'); | ||
| const confirmationViewTabTitle: string = localize('deployContainerAppTabTitle', 'Summary - Deploy Image to Container App'); | ||
| const title: string = localize('deployContainerAppTitle', 'Deploy image to container app'); | ||
| let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input may need to change as well'); |
There was a problem hiding this comment.
nit: Right now, it's not a may, it's guaranteed that it needs to change, right?
Also maybe we should note that a changed input may lead to different prompts?
There was a problem hiding this comment.
I am not sure how granular it needs to be? I will change it from may to need but I think the different prompts may be adding more info than necessary and will make the description longer. If you are that passionate about it though I can make that change 😅
There was a problem hiding this comment.
You should know that I'm not passionate about anything lol. It's also prefixed with a nit 😋
|
Very cool. I bet prompt by prompt progress updates in the future could really elevate that loading page too Oh and let's hold off and merging this until the next release cycle. I'm about to send off the current build for test |
|
Okay we released, so should be okay to start merging new changes! |
4 participants
This add a new command using
CopilotUserInputso copilot will provide all suggestions for the prompt steps.Here is a video of how the new process looks (some of the wording in the video has been changed):
DeployToContainerAppWitCopilot.mp4
Essentially what happens is once the command starts running a loading web view panel screen will pop up. Then once the copilot responses have generated the summary view will pop up where users can either confirm or make edits.
Todo: