Detect new NodeJs model during "Init for VS Code"#3586
Merged
Conversation
alexweininger
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now "Init for VS Code" always defaults to the v3 model. My fix uses the version of the "@azure/functions" dependency to detect the model version. Also, since the new model can put ".ts" and ".js" files anywhere, I'm checking for the "typescript" dev dependency to determine if it's a TypeScript or JavaScript project instead.
Lastly, I noticed some code in the repo that was basically doing the same thing as me so I consolidated that a bit.