Update .NET Isolated detection to check against the template ID#3644
Merged
MicroFish91 merged 1 commit intomainfrom Apr 10, 2023
Merged
Update .NET Isolated detection to check against the template ID#3644MicroFish91 merged 1 commit intomainfrom
MicroFish91 merged 1 commit intomainfrom
Conversation
bwateratmsft
approved these changes
Apr 10, 2023
Member
|
Id definitely seems like the better way. It seems unlikely that it will change as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3642
Changing the value we check against... If we set up a project with another template before we add Durable Functions Orchestration,
projectTemplateKeymay equal an empty string (it wasn't obvious to me why but I didn't dig too deeply). This causesisDotnetIsolatedto be a false negative. Checking the template ID seems to be a more robust fix.. though please let me know if there's a better known value we should be checking against instead.