Merged
Conversation
alexweininger
commented
Jun 12, 2023
| "webpack-cli": "^4.6.0" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/arm-appinsights": "^4.0.0", |
Member
Author
There was a problem hiding this comment.
Sadly the App Insights SDK hasn't GA'd their Track 2 version. So we need to use an alpha build.
bwateratmsft
previously approved these changes
Jun 13, 2023
Member
|
Not really sure why webpack is freaking out. Unless you specify the "webworker" target, it should only be targeting node. |
Member
Author
It also freaked out in VMs. I had to explicitly specific target: node to fix it. Very weird. |
bwateratmsft
previously approved these changes
Jun 13, 2023
bwateratmsft
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully converts extension to Track 2 SDKs.
@azure/ms-rest-jsdependency@azure/core-client,@azure/core-rest-pipeline,@microsoft/vscode-azureresources-api, and@microsoft/vscode-azext-azureappsettings.