Add .net8.dll and and check for it. Remove .net5 since it is EOL#3841
Merged
Add .net8.dll and and check for it. Remove .net5 since it is EOL#3841
Conversation
alexweininger
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a known issue with .NET 7/8 right now with debugging:
dotnet/vscode-csharp#5980
dotnet/vscode-csharp#6273
I downloaded Dev Kit and that did fix it though.
Based off this PR:
https://github.com/microsoft/vscode-azurefunctions/pull/2923/files#diff-d06cae31d33de2a6a7cd19c5779ab1d96141757b2f2a2dd7bf1f3a0ae10bceef
Didn't add the backup templates yet. I think that's okay since they're still in preview anyway. I didn't want to mess with updating backup templates until I fix the tests though.