Add EventGrid Cloud Event templates for .NET to verified list#3916
Merged
hossam-nasr merged 3 commits intomainfrom Nov 29, 2023
Merged
Add EventGrid Cloud Event templates for .NET to verified list#3916hossam-nasr merged 3 commits intomainfrom
hossam-nasr merged 3 commits intomainfrom
Conversation
nturinski
approved these changes
Nov 29, 2023
Member
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
The tests that are currently failing are unrelated to Hossam's changes. Latest version of TypeScript templates don't include the CosmosDB trigger for some reason. I've reached out to the partner team about it already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in title, add the new "EventGrid Cloud Event" templates to the verified list. The only tests failing now should be the TypeScript template count and the .NET isolated back up template count, which do not appear to be related to my changes.