Skip to content

Fix creating a function app with no workspace open #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
motm32 merged 2 commits into from
Mar 29, 2024
Merged

Fix creating a function app with no workspace open #4061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
630beb2
add workspace check
motm32 Mar 28, 2024
198b8f2
more changes
motm32 Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/createFunctionApp/containerImage/detectDockerfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export async function detectDockerfile(context: ICreateFunctionAppContext): Prom
context.rootPath = workspacePath;

//check for host.json location
if (!(await isFunctionProject(workspacePath))) {
if (await isFunctionProject(workspacePath)) {
const files = (await findFiles(context.workspaceFolder, `*/${hostFileName}`));
if (files.length === 0) {
Copy link
Copy Markdown
Member

@nturinski nturinski Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You honestly probably don't need these checks anymore either.

Copy link
Copy Markdown
Contributor Author

@motm32 motm32 Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline and the checks are still needed.

throw new Error(localize('noHostJson', 'No host.json file found in the current workspace.'));
Expand Down
⚡