Skip to content

Fix error on deployment #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
motm32 merged 3 commits into from
Apr 9, 2025
Merged

Fix error on deployment #4477

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3fb368
add try catch
motm32 Apr 9, 2025
e3e5c71
small changes
motm32 Apr 9, 2025
1cd244c
empty
motm32 Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions src/commands/createFunctionApp/stacks/getStackPicks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,54 +380,54 @@ export async function showEolWarningIfNecessary(context: ISubscriptionActionCont
}

async function getEOLDate(context: ISubscriptionActionContext, options: eolWarningOptions): Promise<{ endOfLife: Date | undefined, displayVersion: string }> {
let endOfLife: Date | undefined = undefined;
let displayVersion: string = '';
try {
const stacks = options.isFlex ?
(await getFlexStacks(context, options.location)).filter(s => options.runtime === s.value) :
(await getStacks(context)).filter(s => options.runtime === s.value);
const versionFilteredStacks = stacks[0].majorVersions.filter(mv => mv.minorVersions.some(minor => options.isFlex ? minor.stackSettings.linuxRuntimeSettings?.runtimeVersion : minor.stackSettings.windowsRuntimeSettings?.runtimeVersion === options.version));
const filteredStack = versionFilteredStacks[0].minorVersions.find(minor => options.isFlex ? minor.stackSettings.linuxRuntimeSettings?.runtimeVersion : minor.stackSettings.windowsRuntimeSettings?.runtimeVersion === options.version);
const displayVersion = nonNullValue(filteredStack?.displayText);
displayVersion = nonNullValue(filteredStack?.displayText);
const endOfLifeDate = options.isFlex ?
filteredStack?.stackSettings.linuxRuntimeSettings?.endOfLifeDate :
filteredStack?.stackSettings.windowsRuntimeSettings?.endOfLifeDate;
if (endOfLifeDate) {
const endOfLife = new Date(endOfLifeDate)
return {
endOfLife,
displayVersion
}
}
return {
endOfLife: undefined,
displayVersion
}
} catch {
return {
endOfLife: undefined,
displayVersion: ''
endOfLife = new Date(endOfLifeDate)
}
} catch (error) {
// No need to handle the error here
}

return {
endOfLife,
displayVersion
}

}

async function getEOLLinuxFxVersion(context: ISubscriptionActionContext, linuxFxVersion: string): Promise<{ endOfLife: Date | undefined, displayVersion: string }> {
const stacks = (await getStacks(context)).filter(s =>
s.majorVersions.some(mv =>
mv.minorVersions.some(minor => minor.stackSettings.linuxRuntimeSettings?.runtimeVersion === linuxFxVersion)
)
);
const versionFilteredStacks = stacks[0].majorVersions.filter(mv => mv.minorVersions.some(minor => minor.stackSettings.linuxRuntimeSettings?.runtimeVersion === linuxFxVersion));
const filteredStack = versionFilteredStacks[0].minorVersions.find(minor => minor.stackSettings.linuxRuntimeSettings?.runtimeVersion === linuxFxVersion);
const displayVersion = filteredStack?.displayText ?? localize('unknownVersion', 'Unknown version');
const endOfLifeDate = filteredStack?.stackSettings.linuxRuntimeSettings?.endOfLifeDate;
if (endOfLifeDate) {
const endOfLife = new Date(endOfLifeDate)
return {
endOfLife,
displayVersion
let endOfLife: Date | undefined = undefined;
let displayVersion: string = '';
try {
const stacks = (await getStacks(context)).filter(s =>
s.majorVersions.some(mv =>
mv.minorVersions.some(minor => minor.stackSettings.linuxRuntimeSettings?.runtimeVersion === linuxFxVersion)
)
);
const versionFilteredStacks = stacks[0].majorVersions.filter(mv => mv.minorVersions.some(minor => minor.stackSettings.linuxRuntimeSettings?.runtimeVersion === linuxFxVersion));
const filteredStack = versionFilteredStacks[0].minorVersions.find(minor => minor.stackSettings.linuxRuntimeSettings?.runtimeVersion === linuxFxVersion);
displayVersion = filteredStack?.displayText ?? localize('unknownVersion', 'Unknown version');
const endOfLifeDate = filteredStack?.stackSettings.linuxRuntimeSettings?.endOfLifeDate;
if (endOfLifeDate) {
endOfLife = new Date(endOfLifeDate)
}
} catch (error) {
// No need to handle the error here
}

return {
endOfLife: undefined,
endOfLife,
displayVersion
}
}
⚡