Skip to content

Use the v1 index.json for all templates not just v2#4652

Merged
nturinski merged 1 commit intomainfrom
nat/indexV1Json
Aug 11, 2025
Merged

Use the v1 index.json for all templates not just v2#4652
nturinski merged 1 commit intomainfrom
nat/indexV1Json

Conversation

@nturinski
Copy link
Copy Markdown
Member

Fixes #4646
Fixes #4599

@nturinski nturinski requested a review from a team as a code owner August 11, 2025 21:54
Copy link
Copy Markdown
Member

@alexweininger alexweininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tl;dr this? For me and future us?

@nturinski
Copy link
Copy Markdown
Member Author

Sure. Basically, at some point, the templates team stopped maintaining the v2 section of the templates feed for index-v2.json. Remember, templates were broken into v1 and v2 (though as far as I know, Python is the only runtime that uses v2. Typescript/Javascript programming model is still hard-coded.)

However, the decision to completely deprecate the index-v2.json was made a few weeks ago, so newer versions (I believe it's at 4.22.0 now) are not being added to the list which was causing the bug.

The templates team still maintains the old index.json where you have to build the urls yourself. I was already using it for the v2 templates, so now I'm just doing it for all the templates.

@nturinski nturinski merged commit 1d8ef94 into main Aug 11, 2025
2 checks passed
@nturinski nturinski deleted the nat/indexV1Json branch August 11, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants