Skip to content

Fix custom handler runtimes response due to Stacks API regression#4712

Merged
nturinski merged 5 commits intomainfrom
nat/flexSku
Sep 15, 2025
Merged

Fix custom handler runtimes response due to Stacks API regression#4712
nturinski merged 5 commits intomainfrom
nat/flexSku

Conversation

@nturinski
Copy link
Copy Markdown
Member

Due to a regression in the stacks API, we have to add a queryParam sku that specifies that we want FC1 results. Without it, Custom runtimes do not show up.

However, when you add the query parameters, for some reason, the SKU property is now an array of all possible SKUs instead of just FC1 (which is the old behavior).

We used to be able to assume the first result, but had to change that behavior.

Old payload:
image

New payload:
image

@nturinski nturinski requested a review from a team as a code owner September 10, 2025 22:17
Copy link
Copy Markdown
Contributor

@MicroFish91 MicroFish91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect at some point the Stacks API team will want to fix this? Wondering if there is more we should try to do in anticipation of if they revert back to the behavior they had before the regression

@nturinski
Copy link
Copy Markdown
Member Author

nturinski commented Sep 15, 2025

They are planning to fix this, but even if they do, it shouldn't impact the changes that I made.

I guess key word is shouldn't...

EDIT:

That being said, I think having the find logic in the skus array is probably still the better pattern than assuming [0]. It should be overall more resilient.

@nturinski nturinski merged commit 2c97ddb into main Sep 15, 2025
2 checks passed
@nturinski nturinski deleted the nat/flexSku branch September 15, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants