Skip to content

Always verify and update app connection strings#4853

Merged
MicroFish91 merged 1 commit intomainfrom
mwf/fix-app-settings
Dec 4, 2025
Merged

Always verify and update app connection strings#4853
MicroFish91 merged 1 commit intomainfrom
mwf/fix-app-settings

Conversation

@MicroFish91
Copy link
Copy Markdown
Contributor

@MicroFish91 MicroFish91 commented Dec 4, 2025

Closes #4843

This diff is wild. I only made two small changes. My guess is that since I wrapped the logic in an if block, all the inner logic needed to be indented, and so it's registering as me changing all these lines when I really didn't change the logic much at all.

My changes were:

  1. I pulled out appSettings.properties into its own parent if-block
  2. I moved the two line logic below up one level so that it always executes regardless of if it is a flex consumption app:
const updatedRemoteConnection: boolean = await verifyAndUpdateAppConnectionStrings(context, durableStorageType, appSettings.properties);
updateAppSettings ||= updatedRemoteConnection;

@MicroFish91 MicroFish91 requested a review from a team as a code owner December 4, 2025 01:05
@MicroFish91 MicroFish91 merged commit 5ced605 into main Dec 4, 2025
2 checks passed
@MicroFish91 MicroFish91 deleted the mwf/fix-app-settings branch December 4, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No functions display in the Flex Consumption Function App if the “Functions” node is expanded before MSSQL Durable project deployment

2 participants