Don't call for storageConnetionString if it's not needed#4929
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR avoids unnecessarily fetching the storage connection string when creating a Flex function app with managed identity, which previously caused errors for storage accounts with SAS disabled. It also replaces hard-coded core.windows.net storage endpoint suffixes with environment-aware values for multi-cloud support.
Changes:
- Skip fetching
storageConnectionStringwhen creating a Flex app with managed identity, since only service URIs are used in that scenario. - Extract a
getStorageEndpointSuffixhelper that reads the storage endpoint suffix from the Azure environment (with fallback), replacing hard-codedcore.windows.net. - Use
nonNullPropas a runtime assertion onstorageConnectionStringat all usage sites to fail fast if it's unexpectedlyundefined.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/utils/managedIdentityUtils.ts |
Added getStorageEndpointSuffix helper and replaced hard-coded core.windows.net in blob/queue/table service URIs with the environment-aware suffix. |
src/commands/createFunctionApp/FunctionAppCreateStep.ts |
Conditionally fetches storageConnectionString only when needed; moved plan-type boolean declarations earlier; wrapped usages in nonNullProp assertions. |
bwateratmsft
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4900
For creating flex + managed identity,
storageConnectionStringis never used but still computed. That's the unnecessary call that triggers the error since it's not available with storage accounts that have SAS turned off.Also have a fallback for storage endpoint suffix, but it was previously hard-coded before, so it probably didn't work for other clouds.