Skip to content

Fix containerized .NET project creation failing with exit code 73 #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nturinski merged 3 commits into from
Apr 1, 2026
Merged

Fix containerized .NET project creation failing with exit code 73 #4956

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
367fe0f
Fix containerized .NET project creation failing with exit code 73
alexweininger Apr 1, 2026
d0de05a
Address PR feedback: use withFlagArg and always pass --force
alexweininger Apr 1, 2026
6bc2e3e
Changes so that we are not force overwriting the files
Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/createNewProject/ProjectCreateStep/DotnetProjectCreateStep.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class DotnetProjectCreateStep extends ProjectCreateStepBase {
templateArgs.Framework = context.workerRuntime.targetFramework;
}

await executeDotnetTemplateCreate(context, version, projTemplateKey, context.projectPath, identity, templateArgs);
await executeDotnetTemplateCreate(context, version, projTemplateKey, context.projectPath, identity, templateArgs, { force: !!context.containerizedProject });
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the non-containerized path, confirmOverwriteExisting prompts the user about overwriting existing files, but the subsequent dotnet new invocation will still refuse to overwrite on collisions unless --force is passed. Since executeDotnetTemplateCreate now supports force, consider wiring the prompt result (or presence of conflicts) into this call so the UX matches the actual behavior (or otherwise clarify that the prompt is informational only).

Copilot uses AI. Check for mistakes.

await setLocalAppSetting(context, context.projectPath, ConnectionKey.Storage, '', MismatchBehavior.Overwrite);
}
Expand Down
2 changes: 2 additions & 0 deletions src/templates/dotnet/executeDotnetTemplateCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export async function executeDotnetTemplateCreate(
workingDirectory: string | undefined,
identity: string,
templateArgs: Record<string, string>,
options?: { force?: boolean },
): Promise<void> {
const templateDir = getDotnetTemplateDir(context, version, projTemplateKey);
const itemNupkg = path.join(templateDir, itemNupkgFileName);
Expand Down Expand Up @@ -102,6 +103,7 @@ export async function executeDotnetTemplateCreate(
...Object.entries(templateArgs)
.filter(([, value]) => value !== undefined && value !== '')
.map(([key, value]) => withNamedArg(`--${key}`, value, { shouldQuote: true })),
...(options?.force ? [withArg('--force')] : []),
Comment thread
alexweininger marked this conversation as resolved.
Outdated
)();

await cpUtils.executeCommand(
Expand Down
Loading
⚡