This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Fix #133 - Azure Environment Selector (Resubmitted)#151
Open
creativekinetix wants to merge 5 commits intomicrosoft:mainfrom
Open
Fix #133 - Azure Environment Selector (Resubmitted)#151creativekinetix wants to merge 5 commits intomicrosoft:mainfrom
creativekinetix wants to merge 5 commits intomicrosoft:mainfrom
Conversation
…anagementClient
|
@creativekinetix , just a heads up - I am busy doing some time-sensitive work (for BUILD) so it might take me some time to get back to this review. I will try to get back to this as soon as I can. |
Author
|
@joechung-msft, I appreciate the update. Let me know if there is anything I can do to help. |
There was a problem hiding this comment.
First off, thank you so much for doing this!
There are "management.azure.com" URLs that should be replaced with the resource manager endpoint URL depending on the environment:
- src/utils/logic-app/connectionReferenceUtils.ts
- src/utils/logic-app/designerUtils.ts
- src/utils/logic-app/monitoringViewUtils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #133 - Azure Environment Selector (Resubmitted)
Resubmitting PR (previous PR #150 closed while I sorted things out).
I was able to update
vscode-azureextensionuito v0.17.1 which is the version the fix for Azure Government was introduced. I coupled the update with my previous changes where thebaseUriparameter is passed intoLogicAppsManagementClient()and got to a 95% working solution.I have tested changes on both Azure Commercial and Azure Government. The following are the results.
ms-rest.ServiceClientCredentials.signRequest()instead of theLogicAppsManagementClient.