Fix displaying Logic Apps as Function Apps#332
Merged
alexweininger merged 4 commits intomainfrom Jul 13, 2022
Merged
Conversation
| } | ||
|
|
||
| export function isAppServiceApp(resource: GenericResource): boolean { | ||
| return !isFunctionApp(resource) && !isLogicApp(resource); |
Contributor
There was a problem hiding this comment.
This should include a resource type check, or else it would return true for everything that is not a function or logic app (e.g., true for a storage account).
Something like:
Suggested change
| return !isFunctionApp(resource) && !isLogicApp(resource); | |
| return resource.type.toLowerCase() === 'microsoft.web/sites' && | |
| !isFunctionApp(resource) && | |
| !isLogicApp(resource); |
Also, doesn't need to be in this PR but it's increasingly clear we need to define our own resource type enumeration--which has separate entries for App Service, Functions, and Logic Apps--and have a single function in utils (or azureutils?) to normalize GenericResource -> that type. Then we can stop needing all these toLowerCase() and type/kind checks all over.
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
bwateratmsft
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246