When sub or group is refreshed, refresh the children as well#339
When sub or group is refreshed, refresh the children as well#339
Conversation
|
@alexweininger didn't microsoft/vscode-azurestorage#294 do this? |
|
Once it's resolved, I don't think that resolving it again will do anything. Since |
The logic added in 294 only re-resolves if a new resolver has been registered that matches the resource |
I don't think I'm ready to get rid of the refresh button on the ribbon... but you make a good point here. It really doesn't do much currently |
I think when we move to v2, we could probably fix it not refreshing anything so probably good to just leave it for now. |
Fixes #349
When "refresh" is triggered on the root or a parent, it will only call its refresh, and then call
loadMoreChildrenon itself. However, becauseloadMoreChildrenImpldoesn't actually create new tree items (since we are caching all of theAppResourceTreeItems), refreshing the root, the subscription, and the groups didn't actually do anything.By adding
refreshImpltoSubscriptionTreeItemandGroupTreeItemBase, theAppResourceTreeItemswill actually get refreshed now and it'll be a meaningful refresh.I can't fix the root level refresh without affecting performance because if I call refresh in
SubscriptionTreeItem.loadMoreChildrenImpl, it will activate all of the extensions at once.The root level refresh only works for subscription filtering so I would almost opt to get rid of the refresh button on the ribbon and add it to the groups themselves. It would looks like this: