Skip to content

Add shortcut to switching to sovereign cloud within the tenant view #926

Merged
motm32 merged 19 commits intomainfrom
meganmott/sovereignCloud
Dec 6, 2024
Merged

Add shortcut to switching to sovereign cloud within the tenant view #926
motm32 merged 19 commits intomainfrom
meganmott/sovereignCloud

Conversation

@motm32
Copy link
Copy Markdown
Contributor

@motm32 motm32 commented Sep 17, 2024

This allows users to quickly change their sovereign cloud setting without having to go into the user settings.

The shortcut lives here under the gear icon:
image

There is also a command palette command titiled: Azure: Configure Sovereign Cloud

This brings up the below quick pick. The names correspond with the names on the setting. When an item is selected the setting microsoft-sovereign-cloud.environment is changed to the corresponding value.

(I included the generic azure one so user could switch back easily)

image

I tested this by switching between an Azure China account and a default Azure account and had no issues.

@motm32 motm32 requested a review from a team as a code owner September 17, 2024 22:34
@alexweininger
Copy link
Copy Markdown
Member

alexweininger commented Sep 17, 2024

Can you put a screenshot of the quick pick please

@motm32
Copy link
Copy Markdown
Contributor Author

motm32 commented Sep 17, 2024

Can you put a screenshot of the quick pick please

Yup I'll edit the description to add that

@alexweininger
Copy link
Copy Markdown
Member

just some quick feedback: Maybe we can put (Default) in the description of the "Azure" normal option?

@motm32
Copy link
Copy Markdown
Contributor Author

motm32 commented Sep 18, 2024

just some quick feedback: Maybe we can put (Default) in the description of the "Azure" normal option?

Yup I'll do that!

@alexweininger
Copy link
Copy Markdown
Member

Also I think we'll merge this after we merge the tenant view PR. There might be other small features like this on top of the tenant view that we want to add.

@motm32
Copy link
Copy Markdown
Contributor Author

motm32 commented Sep 18, 2024

Also I think we'll merge this after we merge the tenant view PR. There might be other small features like this on top of the tenant view that we want to add.

Sounds good I'll change the branch to main before we merge this.

Base automatically changed from meganmott/tenantView to main December 6, 2024 01:11
{ label: 'Azure (Default)', data: '' },
{ label: 'Azure China', data: 'ChinaCloud' },
{ label: 'Azure US Government', data: 'USGovernment' },
{ label: 'A custom Microsoft Sovereign Cloud', data: 'custom' }
Copy link
Copy Markdown
Member

@alexweininger alexweininger Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they pick custom, should we take them to the setting page so they can actually configure it? We can make this change later though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah we should change the custom since it will cause an error at the moment

alexweininger
alexweininger previously approved these changes Dec 6, 2024
alexweininger
alexweininger previously approved these changes Dec 6, 2024
@motm32 motm32 merged commit f61558e into main Dec 6, 2024
@motm32 motm32 deleted the meganmott/sovereignCloud branch December 6, 2024 22:15
@microsoft microsoft locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants