eng: Linting: auto-fix

eslint.config.mjs

@@ -0,0 +1,14 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See LICENSE.md in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { azExtEslintRecommended } from '@microsoft/vscode-azext-eng/eslint'; // Other configurations exist
+import { defineConfig, globalIgnores } from 'eslint/config';
+
+export default defineConfig([
+    globalIgnores([
+        'test/testProject/**',
+    ]),
+    azExtEslintRecommended,
+]);

package.json

@@ -455,8 +455,7 @@
         "cleanReadme": "gulp cleanReadme",
         "compile": "tsc -watch",
         "package": "vsce package --githubBranch main",
-        "lint": "eslint --ext .ts .",
-        "lint-fix": "eslint --ext .ts . --fix",
+        "lint": "eslint --max-warnings 0",
         "pretest": "npm run webpack-prod",
         "test": "node ./out/test/runTest.js",
         "webpack": "npm run build && gulp webpack-dev",

src/commands/cli/getNewestSwaCliVersion.ts

@@ -21,7 +21,7 @@ export async function getNewestSwaCliVersion(context: IActionContext): Promise<s
             method: 'GET',
             url: `https://registry.npmjs.org/${swaCliPackageName}`
         }, 15000, undefined);
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+         
         const packageMetadata: IPackageMetadata = <IPackageMetadata>response.parsedBody;
         return packageMetadata["dist-tags"].latest;
     } catch (error) {

src/commands/cli/swaCliTask.ts

@@ -32,7 +32,7 @@ export function registerSwaCliTaskEvents(): void {
 }
 
 function isSwaCliTask(task: vscode.Task): boolean {
-    return !!(task.source === swa && task.execution instanceof vscode.ShellExecution && task.execution?.command === swa)
+    return !!(task.source === swa && task.execution instanceof vscode.ShellExecution && task.execution?.command === swa);
 }
 
 function stopSwaTaskIfRunning(workspaceFolder: vscode.WorkspaceFolder): void {

src/commands/cli/validateSwaCliIsLatest.ts

@@ -53,7 +53,7 @@ export async function validateStaticWebAppsCliIsLatest(): Promise<void> {
                 let result: vscode.MessageItem;
 
                 do {
-                    result = await context.ui.showWarningMessage(message, update, DialogResponses.learnMore, DialogResponses.dontWarnAgain)
+                    result = await context.ui.showWarningMessage(message, update, DialogResponses.learnMore, DialogResponses.dontWarnAgain);
                     if (result === DialogResponses.learnMore) {
                         await openUrl(installSwaCliUrl);
                     } else if (result === update) {

src/commands/createRepo/RepoCreateStep.ts

@@ -41,7 +41,7 @@ export class RepoCreateStep extends AzureWizardExecuteStep<IStaticWebAppWizardCo
         const remoteName: string = nonNullProp(context, 'newRemoteShortname');
 
         try {
-            await repo.addRemote(remoteName, gitHubRepoRes.clone_url)
+            await repo.addRemote(remoteName, gitHubRepoRes.clone_url);
             const branch: Branch = await repo.getBranch('HEAD');
             const pushingBranch: string = localize('pushingBranch', 'Pushing local branch "{0}" to GitHub repository "{1}"...', branch.name, context.newRepoName);
             ext.outputChannel.appendLog(pushingBranch);

src/commands/createStaticWebApp/OutputLocationStep.ts

@@ -22,7 +22,7 @@ export class OutputLocationStep extends AzureWizardPromptStep<IStaticWebAppWizar
             learnMoreLink: 'https://aka.ms/SwaOutLoc',
             validateInput: (value: string): string | undefined => {
                 if (value === angularOutputLocation) {
-                    return localize('fillProjectName', 'Fill in the name of your Angular project.')
+                    return localize('fillProjectName', 'Fill in the name of your Angular project.');
                 }
                 return validateLocationYaml(value, 'output_location');
             }

src/commands/createStaticWebApp/createStaticWebApp.ts

@@ -77,7 +77,7 @@ export async function createStaticWebApp(context: IActionContext & Partial<ICrea
                     context.telemetry.properties.rootHasSrcFolder = (await AzExtFsExtra.pathExists(Uri.joinPath(folder.uri, NodeConstants.srcFolderName))).toString();
 
                     const subfolderDetectorResults: DetectorResults[] = [];
-                    const subWithSrcFolder: string[] = []
+                    const subWithSrcFolder: string[] = [];
                     const subfolders = await getSubFolders(context, folder.uri);
                     for (const subfolder of subfolders) {
                         const subResult = await detector.detect(subfolder);
@@ -157,7 +157,7 @@ export async function createStaticWebApp(context: IActionContext & Partial<ICrea
     executeSteps.push(new VerifyProvidersStep([webProvider]));
     executeSteps.push(new StaticWebAppCreateStep());
 
-    const wizard: AzureWizard<IStaticWebAppWizardContext> = new AzureWizard(wizardContext, {
+    const wizard = new AzureWizard<IStaticWebAppWizardContext>(wizardContext, {
         title,
         promptSteps,
         executeSteps,

src/commands/github/jobLogs/GitHubLogContentProvider.ts

@@ -33,7 +33,7 @@ export async function openGitHubLogContent(node: JobTreeItem | StepTreeItem, con
 
 export class GitHubLogContent {
     private _content: string;
-    private _foldingRanges: FoldingRange[]
+    private _foldingRanges: FoldingRange[];
 
     constructor(content: string, foldingRanges: FoldingRange[]) {
         this._content = content;

src/commands/openYAMLConfigFile.ts

@@ -116,9 +116,9 @@ export async function tryGetSelection(context: IActionContext, configDocument: T
                     return configDocument.validateRange(new Range(startPosition, endPosition));
                 }
             } else if ('items' in yamlNode) {
-                yamlNodes.push(...yamlNode.items)
+                yamlNodes.push(...yamlNode.items);
             } else if ('value' in yamlNode && typeof yamlNode.value === 'object') {
-                yamlNodes.push(yamlNode.value as YamlNode)
+                yamlNodes.push(yamlNode.value as YamlNode);
             }
 
             yamlNode = yamlNodes.pop();

src/constants.ts

@@ -27,7 +27,7 @@ export const openExistingProject = 'openExistingProject';
 export const onlyGitHubSupported: string = localize('onlyGitHubSupported', 'Only Static Web Apps linked to GitHub are supported at this time.');
 
 export const isStartGroup = (t: string): boolean => /##\[group\]/.test(t);
-export const isEndGroup = (t: string): boolean => /##\[endgroup\]/.test(t)
+export const isEndGroup = (t: string): boolean => /##\[endgroup\]/.test(t);
 
 export const githubAuthProviderId: string = 'github';
 // same scopes as the GitHub extension so we won't have to prompt for auth again

src/debug/StaticWebAppDebugProvider.ts

@@ -33,7 +33,7 @@ export class StaticWebAppDebugProvider implements DebugConfigurationProvider {
 
             const appFolders = await detectAppFoldersInWorkspace(context, folder);
             context.telemetry.measurements.appCount = appFolders.length;
-            const foundPresets: IBuildPreset[] = []
+            const foundPresets: IBuildPreset[] = [];
             appFolders.forEach((appFolder) => {
                 const buildPreset = buildPresets.find((preset) => appFolder.frameworks.find((info) => info.framework === preset.displayName));
 

src/detectors/node/NodeDetector.ts

@@ -144,7 +144,7 @@ export class NodeDetector {
             const devDependencies = packageJson.devDependencies;
             for (const framework of Object.keys(NodeConstants.DevDependencyFrameworkKeyWordToName)) {
                 if (devDependencies[framework]) {
-                    detectedFrameworkResult.push({ framework: NodeConstants.DevDependencyFrameworkKeyWordToName[framework as keyof typeof NodeConstants.DevDependencyFrameworkKeyWordToName], version: devDependencies[framework] })
+                    detectedFrameworkResult.push({ framework: NodeConstants.DevDependencyFrameworkKeyWordToName[framework as keyof typeof NodeConstants.DevDependencyFrameworkKeyWordToName], version: devDependencies[framework] });
                 }
             }
         }
@@ -153,7 +153,7 @@ export class NodeDetector {
             const dependencies = packageJson.dependencies;
             for (const framework of Object.keys(NodeConstants.DependencyFrameworkKeyWordToName)) {
                 if (dependencies[framework]) {
-                    detectedFrameworkResult.push({ framework: NodeConstants.DependencyFrameworkKeyWordToName[framework as keyof typeof NodeConstants.DependencyFrameworkKeyWordToName], version: dependencies[framework] })
+                    detectedFrameworkResult.push({ framework: NodeConstants.DependencyFrameworkKeyWordToName[framework as keyof typeof NodeConstants.DependencyFrameworkKeyWordToName], version: dependencies[framework] });
                 }
             }
         }

src/errors.ts

@@ -67,7 +67,7 @@ export class GitError extends Error {
                 this.message = localize('missing user info', "Make sure you configure your 'user.name' and 'user.email' in git.");
                 break;
             default:
-                // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, no-case-declarations
+                // eslint-disable-next-line no-case-declarations
                 const hint = (err.stderr || err.message || String(err))
                     .replace(/^error: /mi, '')
                     .replace(/^> husky.*$/mi, '')

src/getExtensionApi.ts

@@ -43,8 +43,9 @@ export async function getGitApi(): Promise<IGit> {
                 if (gitExtension) {
                     const api = gitExtension.getAPI(1);
                     ext.vscodeGitApi = api;
-                } else
+                } else {
                     throw new Error(localize('unableGit', 'Unable to retrieve VS Code Git API. Please ensure git is properly installed and reload VS Code.'));
+                }
             }
 
             return ext.vscodeGitApi;

src/utils/actionUtils.ts

@@ -31,7 +31,7 @@ export function getActionIconPath(data: ActionWorkflowStepData | ActionsGetJobFo
                 colorId = 'testing.iconSkipped';
                 break;
             case Conclusion.Success:
-                id = 'pass'
+                id = 'pass';
                 colorId = 'testing.iconPassed';
                 break;
         }

src/utils/gitHubUtils.ts

@@ -69,7 +69,7 @@ export async function tryGetReposGetResponseData(context: IActionContext, origin
 
 export function hasAdminAccessToRepo(repoData?: ReposGetResponseData): boolean {
     // to create a workflow, the user needs admin access so if it's not true, it will fail
-    return !!repoData?.permissions?.admin
+    return !!repoData?.permissions?.admin;
 }
 
 export async function tryGetRepoDataForCreation(context: IActionContext, localProjectPath?: Uri): Promise<ReposGetResponseData | undefined> {

src/utils/gitUtils.ts

@@ -76,7 +76,7 @@ export async function verifyGitWorkspaceForCreation(context: IActionContext, git
         const gitApi: IGit = await getGitApi();
         try {
             if (gitApi.init) {
-                repo = await gitApi.init(uri)
+                repo = await gitApi.init(uri);
             }
         } catch (err) {
             handleGitError(err);
@@ -113,7 +113,7 @@ export async function verifyGitWorkspaceForCreation(context: IActionContext, git
         }
 
         if (await getApiExport(remoteRepositoriesId)) {
-            buttons.push(openRemoteProjectMsg)
+            buttons.push(openRemoteProjectMsg);
         }
 
         const result: MessageItem | undefined = await window.showInformationMessage(forkSuccess, ...buttons);
@@ -133,7 +133,7 @@ export async function verifyGitWorkspaceForCreation(context: IActionContext, git
     }
 
     const verifiedRepo: Repository = nonNullValue(repo ?? undefined);
-    return { ...gitWorkspaceState, dirty: false, repo: verifiedRepo }
+    return { ...gitWorkspaceState, dirty: false, repo: verifiedRepo };
 }
 
 export async function tryGetRemote(uri?: Uri): Promise<string | undefined> {
@@ -195,7 +195,7 @@ export async function tryGetLocalBranch(): Promise<string | undefined> {
 }
 
 export async function warnIfNotOnDefaultBranch(context: IActionContext, gitState: VerifiedGitWorkspaceState): Promise<void> {
-    const defaultBranch: string | undefined = await tryGetDefaultBranch(context, gitState)
+    const defaultBranch: string | undefined = await tryGetDefaultBranch(context, gitState);
     context.telemetry.properties.defaultBranch = defaultBranch;
     context.telemetry.properties.notOnDefault = 'false';
     const { repo } = gitState;
@@ -228,7 +228,7 @@ export async function gitPull(repo: Repository): Promise<void> {
         try {
             await repo.pull();
         } catch (error) {
-            handleGitError(error)
+            handleGitError(error);
         }
     });
 }
@@ -237,7 +237,7 @@ async function tryGetDefaultBranch(context: IActionContext, gitState: VerifiedGi
     let defaultBranches: string[];
 
     if (gitState.remoteRepo) {
-        defaultBranches = [gitState.remoteRepo.default_branch]
+        defaultBranches = [gitState.remoteRepo.default_branch];
         context.telemetry.properties.defaultBranchSource = 'remoteConfig';
     } else {
         context.telemetry.properties.defaultBranchSource = 'defaultConfig';

src/utils/treeUtils.ts

@@ -20,6 +20,6 @@ export namespace treeUtils {
     }
 
     function getResourcesUri(): Uri {
-        return Uri.joinPath(ext.context.extensionUri, 'resources')
+        return Uri.joinPath(ext.context.extensionUri, 'resources');
     }
 }

src/utils/workspaceUtils.ts

@@ -90,7 +90,7 @@ export async function showNoWorkspacePrompt(context: IActionContext): Promise<vo
         await cloneRepo(context, '');
         context.telemetry.properties.noWorkspaceResult = 'cloneProject';
     } else if (result === openExistingProjectMsg) {
-        await openFolder(context)
+        await openFolder(context);
         context.telemetry.properties.noWorkspaceResult = openExistingProject;
     } else if (result === openRemoteProjectMsg) {
         await commands.executeCommand('remoteHub.openRepository');

test/index.ts

@@ -49,7 +49,7 @@ function addEnvVarsToMochaOptions(options: Mocha.MochaOptions): void {
             if (typeof value === 'string' && !isNaN(parseInt(value))) {
                 value = parseInt(value);
             }
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
             (<any>options)[option] = value;
         }
     }

test/nodeDetector.test.ts

@@ -148,7 +148,7 @@ suite('Node detector', () => {
                 isYarnLockFileValidYamlFormat: false,
             }
         }
-    ]
+    ];
 
     for (const t of testCases) {
         test(t.workspaceFolder, async () => {

test/swaCliTaskProvider.test.ts

@@ -51,7 +51,7 @@ suite('SWA task provider', async () => {
 
                 tasks.forEach((task) => {
                     verifyTaskForkWorkspace(testCase, task);
-                })
+                });
             }
         });
     }

test/testUtils.ts

@@ -17,5 +17,5 @@ export function getWorkspaceUri(testWorkspaceName: string): Uri {
         }
     }
 
-    throw new Error(`Unable to find workspace "${testWorkspaceName}""`)
+    throw new Error(`Unable to find workspace "${testWorkspaceName}""`);
 }