azure: Use BearerChallengePolicy from auth instead of local duplicate#2232
Merged
alexweininger merged 3 commits intomainfrom Mar 20, 2026
Merged
azure: Use BearerChallengePolicy from auth instead of local duplicate#2232alexweininger merged 3 commits intomainfrom
alexweininger merged 3 commits intomainfrom
Conversation
Replace AzExtBearerChallengePolicy and getDefaultScopeFromEndpoint in the azure package with imports from @microsoft/vscode-azext-azureauth. The telemetry properties (challenge, challengeSuccess) are preserved by wrapping the callback at the call site with try/catch for robustness. This adds @microsoft/vscode-azext-azureauth as a dependency of the azure package, consolidating the challenge policy logic in one place. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates Azure bearer challenge handling by replacing a locally duplicated challenge policy with BearerChallengePolicy from @microsoft/vscode-azext-azureauth.
Changes:
- Replaced local
AzExtBearerChallengePolicy/getDefaultScopeFromEndpointwithBearerChallengePolicyfrom@microsoft/vscode-azext-azureauth - Added try/catch around the challenge callback and precomputed the challenge handler
- Added
@microsoft/vscode-azext-azureauth@^6.0.0-alpha.6dependency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| azure/src/createAzureClient.ts | Swaps in shared BearerChallengePolicy, adds telemetry + error handling around challenge callback, removes local duplicate policy/helpers |
| azure/package.json | Adds dependency on @microsoft/vscode-azext-azureauth for the shared challenge policy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
55
to
76
| const handleChallenge = getChallengeHandlerFromCredential(context.createCredentialsForScopes); | ||
| addAzExtPipeline( | ||
| context, | ||
| client.pipeline, | ||
| context.environment.resourceManagerEndpointUrl, | ||
| undefined, | ||
| undefined, | ||
| new AzExtBearerChallengePolicy( | ||
| context, | ||
| getChallengeHandlerFromCredential(context.createCredentialsForScopes), | ||
| context.environment.resourceManagerEndpointUrl | ||
| new BearerChallengePolicy( | ||
| async (challenge) => { | ||
| context.telemetry.properties.challenge = 'true'; | ||
| try { | ||
| const token = await handleChallenge(challenge); | ||
| context.telemetry.properties.challengeSuccess = token ? 'true' : 'false'; | ||
| return token; | ||
| } catch { | ||
| context.telemetry.properties.challengeSuccess = 'false'; | ||
| return undefined; | ||
| } | ||
| }, | ||
| context.environment.resourceManagerEndpointUrl, | ||
| ) | ||
| ); |
Comment on lines
+69
to
+72
| } catch { | ||
| context.telemetry.properties.challengeSuccess = 'false'; | ||
| return undefined; | ||
| } |
Comment on lines
55
to
76
| const handleChallenge = getChallengeHandlerFromCredential(context.createCredentialsForScopes); | ||
| addAzExtPipeline( | ||
| context, | ||
| client.pipeline, | ||
| context.environment.resourceManagerEndpointUrl, | ||
| undefined, | ||
| undefined, | ||
| new AzExtBearerChallengePolicy( | ||
| context, | ||
| getChallengeHandlerFromCredential(context.createCredentialsForScopes), | ||
| context.environment.resourceManagerEndpointUrl | ||
| new BearerChallengePolicy( | ||
| async (challenge) => { | ||
| context.telemetry.properties.challenge = 'true'; | ||
| try { | ||
| const token = await handleChallenge(challenge); | ||
| context.telemetry.properties.challengeSuccess = token ? 'true' : 'false'; | ||
| return token; | ||
| } catch { | ||
| context.telemetry.properties.challengeSuccess = 'false'; | ||
| return undefined; | ||
| } | ||
| }, | ||
| context.environment.resourceManagerEndpointUrl, | ||
| ) | ||
| ); |
- Extract createBearerChallengePolicy() helper to deduplicate policy creation between createAzureClient and createAzureSubscriptionClient - Rethrow errors from challenge handler instead of swallowing them - Log parseError(err).message to telemetry as challengeError on failure Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
bwateratmsft
left a comment
bwateratmsft
left a comment
There was a problem hiding this comment.
LGTM, though of course we need the new package version released
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bwateratmsft
approved these changes
Mar 20, 2026
Contributor
bwateratmsft
left a comment
bwateratmsft
left a comment
There was a problem hiding this comment.
With all these new packages added to the lockfile, we should try to install this package in, e.g., the Resources extension and make sure the bundle size hasn't gone haywire.
This was referenced Mar 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the local
AzExtBearerChallengePolicyandgetDefaultScopeFromEndpointin the azure package with imports from@microsoft/vscode-azext-azureauth, consolidating the challenge policy logic in one place.Changes
BearerChallengePolicyfrom@microsoft/vscode-azext-azureauthAzExtBearerChallengePolicyclass andgetDefaultScopeFromEndpointfunctionchallengeSuccess = 'false'on failure)@microsoft/vscode-azext-azureauth: ^6.0.0-alpha.6as dependencyDepends on
@microsoft/vscode-azext-azureauth@6.0.0-alpha.6published first.