eng: Don't lint coverage output directory#2237
Merged
bwateratmsft merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shared engineering ESLint configuration to avoid linting generated code coverage artifacts, while re-enabling linting for main.js/main.mjs since they’re treated as product code in this package.
Changes:
- Add
coverage/**to the global ESLint ignore list. - Remove
main.jsandmain.mjsfrom the global ESLint ignore list. - Bump
@microsoft/vscode-azext-engversion to1.0.0-alpha.15(and align lockfile).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/src/eslint/eslintConfigs.ts | Adjusts global ignore patterns to skip coverage output and lint main.*js again. |
| eng/package.json | Version bump to 1.0.0-alpha.15. |
| eng/package-lock.json | Lockfile version fields updated to match 1.0.0-alpha.15. |
Files not reviewed (1)
- eng/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexweininger
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts
coverage/**into the lint ignores. It also takesmain.[m]jsout of it--I figured we should lint it since it is technically product code. Consequently, you might get lint errors when upgrading to this version.