Skip to content

eng: Don't lint coverage output directory#2237

Merged
bwateratmsft merged 1 commit intomainfrom
bmw/engCov
Mar 24, 2026
Merged

eng: Don't lint coverage output directory#2237
bwateratmsft merged 1 commit intomainfrom
bmw/engCov

Conversation

@bwateratmsft
Copy link
Copy Markdown
Contributor

This puts coverage/** into the lint ignores. It also takes main.[m]js out of it--I figured we should lint it since it is technically product code. Consequently, you might get lint errors when upgrading to this version.

Copilot AI review requested due to automatic review settings March 24, 2026 17:39
@bwateratmsft bwateratmsft requested a review from a team as a code owner March 24, 2026 17:39
@bwateratmsft bwateratmsft enabled auto-merge (squash) March 24, 2026 17:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the shared engineering ESLint configuration to avoid linting generated code coverage artifacts, while re-enabling linting for main.js/main.mjs since they’re treated as product code in this package.

Changes:

  • Add coverage/** to the global ESLint ignore list.
  • Remove main.js and main.mjs from the global ESLint ignore list.
  • Bump @microsoft/vscode-azext-eng version to 1.0.0-alpha.15 (and align lockfile).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
eng/src/eslint/eslintConfigs.ts Adjusts global ignore patterns to skip coverage output and lint main.*js again.
eng/package.json Version bump to 1.0.0-alpha.15.
eng/package-lock.json Lockfile version fields updated to match 1.0.0-alpha.15.
Files not reviewed (1)
  • eng/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bwateratmsft bwateratmsft merged commit 4c7d85a into main Mar 24, 2026
8 checks passed
@bwateratmsft bwateratmsft deleted the bmw/engCov branch March 24, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants