Skip to content

Disable some Compose features if Docker's extension is installed#75

Merged
bwateratmsft merged 2 commits intomicrosoft:mainfrom
rcjsuen:consider-docker-extension-for-compose
Jun 4, 2025
Merged

Disable some Compose features if Docker's extension is installed#75
bwateratmsft merged 2 commits intomicrosoft:mainfrom
rcjsuen:consider-docker-extension-for-compose

Conversation

@rcjsuen
Copy link
Copy Markdown
Contributor

@rcjsuen rcjsuen commented May 9, 2025

Docker's extension bundles a language server that provides some Compose features that overlap with the ones from the Container Tools extension. Red Hat's YAML extension also does something similar which was previously accounted for. The code has now been changed to disable select Compose features if Docker's extension or Red Hat's YAML extension is installed.

To test this, one should install specific builds of Docker's extension that are being generated by docker/vscode-extension#108.

Docker's extension bundles a language server that provides some Compose
features that overlap with the ones from the Container Tools extension.
Red Hat's YAML extension also does something similar which was
previously accounted for. The code has now been changed to disable
select Compose features if Docker's extension or Red Hat's YAML
extension is installed.

Signed-off-by: Remy Suen <remy.suen@docker.com>
@rcjsuen rcjsuen requested a review from a team as a code owner May 9, 2025 11:27
@rcjsuen rcjsuen marked this pull request as draft May 9, 2025 11:27
@rcjsuen
Copy link
Copy Markdown
Contributor Author

rcjsuen commented May 9, 2025

@bwateratmsft I've converted this to a draft for now. Will switch it back after we've figured out the coordination of things to ensure things are generally smooth and non-disruptive.

@bwateratmsft
Copy link
Copy Markdown
Collaborator

Sounds good. Code looks great, thanks @rcjsuen!

Signed-off-by: Remy Suen <remy.suen@docker.com>
@rcjsuen rcjsuen marked this pull request as ready for review June 3, 2025 20:55
@bwateratmsft bwateratmsft added this to the 2.0.3 milestone Jun 4, 2025
@bwateratmsft bwateratmsft merged commit 6d3f2b2 into microsoft:main Jun 4, 2025
2 checks passed
@rcjsuen rcjsuen deleted the consider-docker-extension-for-compose branch June 4, 2025 14:24
@bwateratmsft
Copy link
Copy Markdown
Collaborator

This is now released in version 2.0.3 of the Container Tools extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants