Skip to content
This repository was archived by the owner on May 20, 2026. It is now read-only.

Commit f470e85

Browse files
digitaraldHarald Kirschner
andauthored
Follow-up fixes for v2 taxonomy (#4071) (#4120)
- Add taxonomyVersion field to telemetry events to distinguish v1/v2 data - Fix prompt/SafetyRules boundary by adding trailing newlines - Consistent bullet formatting for signals in scope definitions Co-authored-by: Harald Kirschner <digitarald@gmail.com>
1 parent 177a295 commit f470e85

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

src/extension/prompt/common/promptCategorizationTaxonomy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ function formatCategoryForPrompt(key: string, def: CategoryDefinition): string {
277277
parts.push(`- Keywords: ${def.keywords.join(', ')}`);
278278
}
279279
if (def.signals?.length) {
280-
parts.push(`Signals: ${def.signals.join(', ')}`);
280+
parts.push(`- Signals: ${def.signals.join(', ')}`);
281281
}
282282
if (def.examples?.length) {
283283
parts.push(`Examples: ${def.examples.map(e => `"${e}"`).join(', ')}`);

src/extension/prompt/node/promptCategorizer.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,7 @@ export class PromptCategorizerService implements IPromptCategorizerService {
285285
"promptCategorization" : {
286286
"owner": "digitarald",
287287
"comment": "Classifies agent requests for understanding user intent and response quality",
288+
"taxonomyVersion": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "comment": "The taxonomy version used for classification (e.g. v2). Used to segment data when taxonomy keys change." },
288289
"sessionId": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "comment": "The chat session identifier" },
289290
"requestId": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "comment": "The extension-generated request identifier, matches panel.request requestId" },
290291
"vscodeRequestId": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "comment": "The VS Code chat request id, for joining with VS Code telemetry events" },
@@ -306,6 +307,7 @@ export class PromptCategorizerService implements IPromptCategorizerService {
306307
this.telemetryService.sendMSFTTelemetryEvent(
307308
'promptCategorization',
308309
{
310+
taxonomyVersion: 'v2',
309311
sessionId: request.sessionId ?? '',
310312
requestId: telemetryMessageId,
311313
vscodeRequestId: request.id ?? '',
@@ -337,6 +339,7 @@ export class PromptCategorizerService implements IPromptCategorizerService {
337339
this.telemetryService.sendInternalMSFTTelemetryEvent(
338340
'promptCategorization',
339341
{
342+
taxonomyVersion: 'v2',
340343
sessionId: request.sessionId ?? '',
341344
requestId: telemetryMessageId,
342345
vscodeRequestId: request.id ?? '',

src/extension/prompts/node/panel/promptCategorization.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class PromptCategorizationPrompt extends PromptElement<PromptCategorizati
2222
'You are an expert classifier for AI coding assistant prompts. Classify developer requests in context of their workspace and active file across domain, intent, time estimate, and scope.',
2323
'You MUST use the categorize_prompt tool to provide your classification.',
2424
generateTaxonomyPrompt(),
25-
].join('\n\n');
25+
].join('\n\n') + '\n\n';
2626

2727
return (
2828
<>

0 commit comments

Comments
 (0)