This repository was archived by the owner on May 20, 2026. It is now read-only.
Follow-up fixes for v2 taxonomy (#4071)#4120
Merged
Merged
Conversation
- Add taxonomyVersion field to telemetry events to distinguish v1/v2 data - Fix prompt/SafetyRules boundary by adding trailing newlines - Consistent bullet formatting for signals in scope definitions
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up to the v2 prompt categorization taxonomy work, ensuring telemetry can distinguish taxonomy versions and that the rendered classification prompt has correct formatting boundaries.
Changes:
- Adds
taxonomyVersion: 'v2'to both MSFT and internalpromptCategorizationtelemetry events (and documents it in the GDPR block). - Fixes the system prompt /
<SafetyRules />boundary by appending a trailing separator (\n\n) to the composed system prompt string. - Aligns taxonomy prompt formatting by rendering
signalsas a bullet (- Signals:) to match- Keywords:.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/extension/prompts/node/panel/promptCategorization.tsx | Adds a trailing separator to avoid taxonomy text running into <SafetyRules />. |
| src/extension/prompt/node/promptCategorizer.ts | Adds and emits taxonomyVersion: 'v2' on both public and internal telemetry events. |
| src/extension/prompt/common/promptCategorizationTaxonomy.ts | Updates prompt formatting so Signals uses the same bullet style as Keywords. |
Contributor
|
Looks good! |
rzhao271
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4071 addressing review comments.
Changes
Add
taxonomyVersionto telemetry — Adds ataxonomyVersion: 'v2'field to both the MSFT and internalpromptCategorizationtelemetry events so dashboards can distinguish v1 vs v2 taxonomy data.Fix prompt/SafetyRules boundary — The system prompt string was rendered immediately before
<SafetyRules />with no separator, causing the taxonomy's last line to run together with safety rules. Adds a trailing\n\n.Consistent signals formatting — Kept
signalsrendering (used by scope definitions) but aligned bullet formatting (- Signals:) with the new- Keywords:style from v2.cc @kevin-m-kent