Validate some untrusted GitHub API responses using validator system#1989
Validate some untrusted GitHub API responses using validator system#1989Copilot wants to merge 8 commits into
Conversation
…all sites Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
|
@copilot For vJobInfo you're validating too strictly! 2025-11-13 18:07:16.529 [error] [GitHubService] Failed to validate job info response: Required field 'pull_request' is missing |
Fixed in f403ecb. Made |
f403ecb to
c74020c
Compare
GitHub API Response Validation - Complete ✅
Supports
makeGitHubAPIRequestfunction returningunknown(untrusted data) instead of typed responses. Callers validate responses using the validator system before use.Room for improvement here, either adding more methods to be validated or setting certain fields to required (would need confirmation from github on which fields are actually required)