This repository was archived by the owner on May 20, 2026. It is now read-only.
nes: fix: don't yield edits when fetch errors or is cancelled#4869
Merged
eleanorjboyd merged 3 commits intoMar 31, 2026
Merged
Conversation
Contributor
Author
|
don't mind -- these're failing because I first incorrectly created the PR against main, but also they're not required and needed 
|
alexr00
approved these changes
Mar 31, 2026
alexr00
left a comment
alexr00
left a comment
Member
There was a problem hiding this comment.
Great to see the tests. Thank you!
alexr00
approved these changes
Mar 31, 2026
alexr00
approved these changes
Mar 31, 2026
eleanorjboyd
approved these changes
Mar 31, 2026
eleanorjboyd
deleted the
ulugbekna/nes-dont-yield-fetch-with-error-candidate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes microsoft/vscode#306810