Skip to content
This repository was archived by the owner on May 20, 2026. It is now read-only.

Add githubMcpServer.channel setting for MCP Insiders mode#4946

Merged
digitarald merged 4 commits into
mainfrom
users/digitarald/github-mcp-channel-setting
Apr 3, 2026
Merged

Add githubMcpServer.channel setting for MCP Insiders mode#4946
digitarald merged 4 commits into
mainfrom
users/digitarald/github-mcp-channel-setting

Conversation

@digitarald

@digitarald digitarald commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Adds a new github.copilot.chat.githubMcpServer.channel dropdown setting (stable / insiders) that sends an X-MCP-Insiders: true header to the GitHub MCP Server when set to insiders.

This enables access to experimental features in the GitHub MCP Server's Insiders mode.

Changes

  • ConfigKey: Added GitHubMcpChannel (string, default 'stable', ConfigType.Simple)
  • Setting schema: String enum with stable/insiders values, tagged experimental
  • GitHubMcpDefinitionProvider: Config change listener, channel getter, X-MCP-Insiders header + |insiders version suffix
  • NLS: Setting description with Learn more link, enum descriptions

Follows the existing pattern of readonly and lockdown settings.

@digitarald digitarald marked this pull request as ready for review April 2, 2026 19:12
Copilot AI review requested due to automatic review settings April 2, 2026 19:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new user-facing setting to choose the GitHub MCP Server “channel” (stable vs insiders) and wires that through to the MCP server definition so the extension can opt into GitHub MCP “Insiders mode”.

Changes:

  • Introduces chat.githubMcpServer.channel configuration key (default stable).
  • Updates GitHubMcpDefinitionProvider to react to channel changes and send X-MCP-Insiders: true (+ version suffix) when set to insiders.
  • Adds configuration schema + NLS strings for the new dropdown setting.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/platform/configuration/common/configurationService.ts Registers new GitHubMcpChannel config key and default value.
src/extension/githubMcp/common/githubMcpDefinitionProvider.ts Applies channel to MCP headers/version and listens for configuration changes.
package.nls.json Adds localized strings for the new setting and enum descriptions.
package.json Adds the public settings schema entry (enum: stable / insiders, tagged experimental).

Comment thread src/platform/configuration/common/configurationService.ts Outdated
Comment thread src/extension/githubMcp/common/githubMcpDefinitionProvider.ts
@digitarald digitarald requested a review from connor4312 April 2, 2026 19:25
connor4312
connor4312 previously approved these changes Apr 2, 2026
@digitarald

Copy link
Copy Markdown
Contributor Author

@copilot fix merge conflict

Co-authored-by: digitarald <8599+digitarald@users.noreply.github.com>

Copilot AI commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

@copilot fix merge conflict

Resolved the merge conflict in package.json (the vscodeCommit hash) by taking the value from main. Commit: bfc7106

@digitarald digitarald enabled auto-merge April 3, 2026 00:49
@digitarald digitarald added this pull request to the merge queue Apr 3, 2026
Merged via the queue into main with commit 1761632 Apr 3, 2026
19 checks passed
@digitarald digitarald deleted the users/digitarald/github-mcp-channel-setting branch April 3, 2026 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants