Skip to content
This repository was archived by the owner on May 20, 2026. It is now read-only.

Update a few more codebase/workspace strings#5016

Merged
mjbvz merged 5 commits into
microsoft:mainfrom
mjbvz:dev/mjbvz/fluffy-octopus
Apr 6, 2026
Merged

Update a few more codebase/workspace strings#5016
mjbvz merged 5 commits into
microsoft:mainfrom
mjbvz:dev/mjbvz/fluffy-octopus

Conversation

@mjbvz

@mjbvz mjbvz commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

We should always mention that these are semantic indexes

mjbvz added 2 commits April 6, 2026 14:49
We should always mention that these are semantic indexes
Copilot AI review requested due to automatic review settings April 6, 2026 22:03
@mjbvz mjbvz enabled auto-merge April 6, 2026 22:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates user-facing strings related to workspace/codebase indexing so the UI more clearly describes the indexing feature (intended to be communicated as semantic indexes).

Changes:

  • Updated the build-index progress/warning messages in the workspace chunk search command.
  • Updated command titles in package.nls.json to include “Semantic Codebase Index” terminology.
Show a summary per file
File Description
src/extension/workspaceChunkSearch/vscode-node/commands.ts Adjusts progress and warning strings shown while triggering remote workspace indexing.
package.nls.json Renames command titles to reference “Semantic Codebase Index”.

Copilot's findings

Comments suppressed due to low confidence (1)

src/extension/workspaceChunkSearch/vscode-node/commands.ts:38

  • The warning message uses “remote workspace index” and includes a trailing space before the concatenation. Given the command label is “Build Semantic Codebase Index”, it would be clearer to use the same “semantic codebase index” phrasing here and drop the extra trailing space to avoid odd formatting in the notification.
			if (triggerResult.isError()) {
				if (triggerResult.err.id !== TriggerRemoteIndexingError.alreadyIndexed.id) {
					vscode.window.showWarningMessage(t`Could not build remote workspace index. ` + '\n\n' + triggerResult.err.userMessage);
					return;
  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment thread src/extension/workspaceChunkSearch/vscode-node/commands.ts
Comment thread package.nls.json Outdated
roblourens
roblourens previously approved these changes Apr 6, 2026
@mjbvz mjbvz added this pull request to the merge queue Apr 6, 2026
@mjbvz mjbvz removed this pull request from the merge queue due to a manual request Apr 6, 2026
@mjbvz

mjbvz commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

Sorry I realized I messed up the merge with some of these strings. Need a re-review

@mjbvz mjbvz enabled auto-merge April 6, 2026 22:42
@mjbvz mjbvz added this pull request to the merge queue Apr 6, 2026
Merged via the queue into microsoft:main with commit 19af311 Apr 6, 2026
9 checks passed
@mjbvz mjbvz deleted the dev/mjbvz/fluffy-octopus branch April 6, 2026 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants