An error "Unknown parameter structure byName..." occurs in the "Dockerfile Language Server" output panel

[v-ruizh]

OS: Windows 10
Build Version: 20210106.8

Repro Steps:

1. Create a .NET Core Console project.
2. Add Docker files to it.
3. Open Dockerfile and check the "Dockerfile Language Server" output panel.

Expect:
There is no error in the "Dockerfile Language Server" output panel.

Actual:
An error "Unknown parameter structure byName..." occurs in the "Dockerfile Language Server" output panel.

(node:13968) UnhandledPromiseRejectionWarning: Error: Unknown parameter structure byName
at computeSingleParam (c:\Users\AzureTest.vscode-insiders\extensions\ms-azuretools.vscode-docker-1.9.5-alpha\dist\dockerfile-language-server-nodejs\lib\server.js:1:211247)
at computeMessageParams (c:\Users\AzureTest.vscode-insiders\extensions\ms-azuretools.vscode-docker-1.9.5-alpha\dist\dockerfile-language-server-nodejs\lib\server.js:1:211410)
at Object.sendNotification (c:\Users\AzureTest.vscode-insiders\extensions\ms-azuretools.vscode-docker-1.9.5-alpha\dist\dockerfile-language-server-nodejs\lib\server.js:1:212089)
at Object.sendDiagnostics (c:\Users\AzureTest.vscode-insiders\extensions\ms-azuretools.vscode-docker-1.9.5-alpha\dist\dockerfile-language-server-nodejs\lib\server.js:1:292320)
at c:\Users\AzureTest.vscode-insiders\extensions\ms-azuretools.vscode-docker-1.9.5-alpha\dist\dockerfile-language-server-nodejs\lib\server.js:1:16962
(node:13968) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:13968) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

[rcjsuen]

See microsoft/vscode-languageserver-node#719.

[dbaeumer]

@rcjsuen can you reproduce this when running out of source? From looking at the code it very likely happens when the server sends the configuration request to the client.

I also noticed that you have this line in your server code

import { FoldingRangeParams, SemanticTokenModifiers, SemanticTokenTypes, SemanticTokensParams } from "vscode-languageserver-protocol";

which might trick webpack into bundling the vscode-languageserver-protocol separately from the vscode-languageserver/node which might explain what you are seeing. The import is actually unnecessary. You should reach to these types using the vscode-languageserver/node import.

[rcjsuen]

@rcjsuen can you reproduce this when running out of source?

@dbaeumer I haven't noticed this error before...but that is not evidence to imply it is a completely new bug or if it has been around for a while.

I also noticed that you have this line in your server code

import { FoldingRangeParams, SemanticTokenModifiers, SemanticTokenTypes, SemanticTokensParams } from "vscode-languageserver-protocol";

which might trick webpack into bundling the vscode-languageserver-protocol separately from the vscode-languageserver/node which might explain what you are seeing. The import is actually unnecessary. You should reach to these types using the vscode-languageserver/node import.

@dbaeumer I've been meaning to clean that up in the past so this is as good a reason as any. I've published a new 0.2.2 release that includes this fix.

[dbaeumer]

@rcjsuen the ParameterStructures got introduced with the latest 6.0.0 release of vscode-jsonrpc. So if you haven't adopted a next release the error didn't exist before.

[rcjsuen]

@rcjsuen the ParameterStructures got introduced with the latest 6.0.0 release of vscode-jsonrpc. So if you haven't adopted a next release the error didn't exist before.

@dbaeumer I was defining ^6.1.1 for vscode-languageserver before but two weeks ago I set it to ^7.0.0.

[dbaeumer]

OK. Let me know if the error is solved for you now.