Skip to content

use https locations for all old schema drafts#268

Merged
aeschli merged 1 commit intomainfrom
aeschli/presidential-quelea
May 19, 2025
Merged

use https locations for all old schema drafts#268
aeschli merged 1 commit intomainfrom
aeschli/presidential-quelea

Conversation

@aeschli
Copy link
Copy Markdown
Collaborator

@aeschli aeschli commented May 19, 2025

No description provided.

@aeschli aeschli self-assigned this May 19, 2025
@aeschli aeschli enabled auto-merge (squash) May 19, 2025 10:25
@vs-code-engineering vs-code-engineering bot added this to the May 2025 milestone May 19, 2025
@aeschli aeschli merged commit 6ce3f10 into main May 19, 2025
3 checks passed
@aeschli aeschli deleted the aeschli/presidential-quelea branch May 19, 2025 10:48
@jeremyfiel
Copy link
Copy Markdown
Contributor

@aeschli This pr introduced invalid JSON Schema $schema values

All of the old drafts ONLY use http because the identifier is http://json-schema.org/draft-0(4/7)/schema#

this was originally fixed in #201 seems to be a different location where you made these changes. I just found intellisense is again suggesting the wrong uris.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants