Revert "Fix spawn calls to use Windows path quoting (#17020)"#17044
Merged
DonJayamanne merged 1 commit intomainfrom Oct 10, 2025
Merged
Revert "Fix spawn calls to use Windows path quoting (#17020)"#17044DonJayamanne merged 1 commit intomainfrom
DonJayamanne merged 1 commit intomainfrom
Conversation
This reverts commit 952a5f7.
DonJayamanne
commented
Oct 10, 2025
| public execObservable(file: string, args: string[], options: SpawnOptions = {}): ObservableExecutionResult<string> { | ||
| const spawnOptions = this.getDefaultOptions(options); | ||
| const proc = spawn(fileToCommandArgument(file), args, spawnOptions); | ||
| const proc = spawn(file, args, spawnOptions); |
Contributor
Author
There was a problem hiding this comment.
We shouldn't quote file paths in spawn here
As the first argument itself is the file, & second is the arguments.
Only cases where the command is a combination of file and arguments do we need to quote the file.
Tyriar
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 952a5f7.
Fixes #17042