[ci] workaround MSVC 14.51 coroutine hard-error in flutter-app test#579
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Flutter sample’s Pester test to work around an MSVC 14.51+ coroutine deprecation hard-error by injecting _SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGS into the Windows runner CMake configuration before building.
Changes:
- Patch
windows/runner/CMakeLists.txtduring Phase 1 (temp project) beforeflutter build windows. - Patch
windows/runner/CMakeLists.txtduring Phase 2 (checked-in sample) beforeflutter build windows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Build Metrics ReportBinary Sizes
Test Results✅ 1198 passed, 1 skipped out of 1199 tests in 452.6s (+29.7s vs. baseline) Test Coverage❌ 17.3% line coverage, 36.3% branch coverage · ✅ no change vs. baseline CLI Startup Time43ms median (x64, Updated 2026-06-16 19:54:49 UTC · commit |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
zateutsch
approved these changes
Jun 16, 2026
chiaramooney
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Usage Example
Related Issue
Type of Change
Checklist
docs/fragments/skills/(if CLI commands/workflows changed)Screenshots / Demo
Additional Notes
AI Description
This pull request modifies the PowerShell test script for the Flutter app sample to address a hard error encountered with MSVC 14.51 related to ``. A workaround is implemented by temporarily modifying the CMake configuration to suppress deprecation warnings during the build process.