Skip to content

[ci] workaround MSVC 14.51 coroutine hard-error in flutter-app test#579

Merged
zateutsch merged 3 commits into
mainfrom
leilzh/fixci
Jun 17, 2026
Merged

[ci] workaround MSVC 14.51 coroutine hard-error in flutter-app test#579
zateutsch merged 3 commits into
mainfrom
leilzh/fixci

Conversation

@lei9444

@lei9444 lei9444 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

Usage Example

Related Issue

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📝 Documentation
  • 🔧 Config/build
  • ♻️ Refactoring
  • 🧪 Test update

Checklist

  • New tests added for new functionality (if applicable)
  • Tested locally on Windows
  • Main README.md updated (if applicable)
  • docs/usage.md updated (if CLI commands changed)
  • Language-specific guides updated (if applicable)
  • Sample projects updated to reflect changes (if applicable)
  • Agent skill templates updated in docs/fragments/skills/ (if CLI commands/workflows changed)

Screenshots / Demo

Additional Notes

AI Description

This pull request modifies the PowerShell test script for the Flutter app sample to address a hard error encountered with MSVC 14.51 related to ``. A workaround is implemented by temporarily modifying the CMake configuration to suppress deprecation warnings during the build process.

# MSVC 14.51+ hard-errors on ; suppress until Flutter updates its runner.
$cmakeFile = Join-Path $script:projectDir "windows\runner\CMakeLists.txt"
if (Test-Path $cmakeFile) {
    $content = Get-Content $cmakeFile -Raw
    if ($content -notlike '*_SILENCE_EXPERIMENTAL_COROUTINE*') {
        $content = $content -replace '(target_compile_definitions\(\$\{BINARY_NAME\} PRIVATE[^)]*)', "`$1`n  _SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGS"
        Set-Content $cmakeFile $content -NoNewline
    }
}

Copilot AI review requested due to automatic review settings June 16, 2026 12:41
@github-actions github-actions Bot added the bug Something isn't working label Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Flutter sample’s Pester test to work around an MSVC 14.51+ coroutine deprecation hard-error by injecting _SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGS into the Windows runner CMake configuration before building.

Changes:

  • Patch windows/runner/CMakeLists.txt during Phase 1 (temp project) before flutter build windows.
  • Patch windows/runner/CMakeLists.txt during Phase 2 (checked-in sample) before flutter build windows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread samples/flutter-app/test.Tests.ps1
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Build Metrics Report

Binary Sizes

Artifact Baseline Current Delta
CLI (ARM64) 31.49 MB 31.49 MB ✅ 0.0 KB (0.00%)
CLI (x64) 31.82 MB 31.82 MB ✅ 0.0 KB (0.00%)
MSIX (ARM64) 13.23 MB 13.23 MB 📈 +0.2 KB (+0.00%)
MSIX (x64) 14.05 MB 14.05 MB 📉 -0.0 KB (-0.00%)
NPM Package 27.52 MB 27.52 MB 📈 +0.2 KB (+0.00%)
NuGet Package 27.62 MB 27.62 MB 📈 +0.2 KB (+0.00%)
VS Code Extension 20.34 MB 20.34 MB 📈 +0.7 KB (+0.00%)

Test Results

1198 passed, 1 skipped out of 1199 tests in 452.6s (+29.7s vs. baseline)

Test Coverage

17.3% line coverage, 36.3% branch coverage · ✅ no change vs. baseline

CLI Startup Time

43ms median (x64, winapp --version) · ✅ no change vs. baseline


Updated 2026-06-16 19:54:49 UTC · commit d4d9942 · workflow run

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@zateutsch zateutsch merged commit 127df99 into main Jun 17, 2026
22 checks passed
@zateutsch zateutsch deleted the leilzh/fixci branch June 17, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants