feat: add support for non-flakes#282
Open
RaitoBezarius wants to merge 1 commit intomicrovm-nix:mainfrom
Open
Conversation
Via flake-compat. Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
Member
|
Do you really need this? |
Contributor
Author
|
I'm not sure there's an easy way to get access to the package set exposed, short of rewriting the flake.nix, right? |
Contributor
Author
|
Happy to drop flake-compat if you prefer me to re-expose it via default.nix and re-import in the flake.nix directly. |
Member
|
Yes, I'd prefer one dependency less in flake.lock for the case where flakes are not used :) |
Contributor
Author
|
Okay, will send a more complicated PR for that, then :). |
Member
|
Let me know if you encounter problems because if the other way becomes too many lines of code we should resort to the flake-compat solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via flake-compat.