chore: replace hostName with fqdnOrHostName

[felbinger]

Using fully qualified domain names as unique identifier for containers improves identification of containers on large (potentially multi tenant) hypervisors.

In the current version using a container name containing a dot doesn't work. I forked microvm.nix and adjusted it so that fqdn's are used by default.

Should we try to upstream this? If yes how?

I drafted this change because merging this would result in breaking changes if networking.domain is being set for a machine.

[SuperSandro2000]

Modules that accept a mere networking.hostName but prefer a fully qualified domain name may use networking.fqdnOrHostName instead.

https://search.nixos.org/options?channel=unstable&show=networking.fqdn&query=networking.fqdn

[felbinger]

I haven't had the time to test yet, will do in the next days...

[felbinger]

I haven't had the time to test yet, will do in the next days...

Ok works. Now this change works without breaking changes if networking.domain is NOT set.

If I am correct, systems that have a domain set will still encounter breaking changes, right?

How should we proceed?

[SuperSandro2000]

@astro how do we could handle this?

[SuperSandro2000]

Also the CI tests are failing for some reason I did not grasp yet.

[astro]

Is this a breaking change only if networking.domain is defined?

[felbinger]

rebased with main and removed irrelevant comment i created while making the initial change

[SuperSandro2000]

Why not add an option for the microvm name that defaults to networking.hostName and which you can change to something else like fqdn?

[felbinger]

Why not add an option for the microvm name that defaults to networking.hostName and which you can change to something else like fqdn?

Works for me, if that's the way to get this change into microvm