[deviantart] handle missing 'src' in deviation_download response#9385
Open
thakoreh wants to merge 1 commit intomikf:masterfrom
Open
[deviantart] handle missing 'src' in deviation_download response#9385thakoreh wants to merge 1 commit intomikf:masterfrom
thakoreh wants to merge 1 commit intomikf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deviation_download API can return a response without a "src" field
when the download limit is hit or when content is subscriber-only.
This causes a KeyError crash in commit().
Instead of crashing, log a warning and skip the download attempt.
If the deviation has a video counterpart, it will still be picked up
by the videos block below.
Fixes #9307
Related: #9072