fix: restore consistency_level int in CollectionSchema.dict(), add name alias#3441
Open
pymilvus-bot wants to merge 1 commit intomilvus-io:masterfrom
Open
fix: restore consistency_level int in CollectionSchema.dict(), add name alias#3441pymilvus-bot wants to merge 1 commit intomilvus-io:masterfrom
pymilvus-bot wants to merge 1 commit intomilvus-io:masterfrom
Conversation
…me alias PR milvus-io#3409 changed CollectionSchema.dict() to emit consistency_level as the human-readable string (ConsistencyLevel.Name(...)) instead of its historical int, breaking public-API back-compat for callers that indexed dict()["consistency_level"] expecting an int — including the milvus e2e test_milvus_client_search_query_default. This restores the int shape and exposes the name under a new consistency_level_name key. Callers who want the human-readable form read the new key; existing callers stay unbroken. See also: milvus-io#2985 Signed-off-by: pymilvus-bot <pymilvus@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pymilvus-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3441 +/- ##
=======================================
Coverage 90.85% 90.85%
=======================================
Files 64 64
Lines 13978 13978
=======================================
Hits 12700 12700
Misses 1278 1278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3409 changed CollectionSchema.dict() to emit consistency_level as
the human-readable string (ConsistencyLevel.Name(...)) instead of its
historical int, breaking public-API back-compat for callers that
indexed dict()["consistency_level"] expecting an int — including the
milvus e2e test_milvus_client_search_query_default.
This restores the int shape and exposes the name under a new
consistency_level_name key. Callers who want the human-readable form
read the new key; existing callers stay unbroken.
See also: #2985