This repository was archived by the owner on Apr 24, 2023. It is now read-only.
[requirejs] use requirejs over require, no simplified commonjs wrapper#19
Merged
minrk merged 1 commit intominrk:masterfrom Dec 5, 2017
Merged
[requirejs] use requirejs over require, no simplified commonjs wrapper#19minrk merged 1 commit intominrk:masterfrom
minrk merged 1 commit intominrk:masterfrom
Conversation
* use requirejs over require variable name to avoid confusion on node. See jupyter/notebook#155 for details. * don't use the requirejs simplified commonjs wrapper http://requirejs.org/docs/api.html#cjsmodule which is slower than a dependency array, and relies on toString parsing. See ipython-contrib/jupyter_contrib_nbextensions#1165 for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use requirejs over require variable name to avoid confusion on node.
See Use "requirejs" instead of "require" jupyter/notebook#155 for details.
don't use the requirejs simplified commonjs wrapper
http://requirejs.org/docs/api.html#cjsmodule
which is slower than a dependency array, and relies on toString parsing.
See Use
requirejsvs.requireipython-contrib/jupyter_contrib_nbextensions#1165for details.