Skip to content

mirage enabled even when using --proxy flag #2558

@Techn1x

Description

@Techn1x

It looks like this PR #2495 released 2 weeks ago under 3.0.0-alpha.4 has removed the config/environment.js file

That config/environment.js file had a usingProxy() function that would set ENV['ember-cli-mirage'].usingProxy to true if proxy flag was set
https://github.com/miragejs/ember-cli-mirage/pull/2495/files#diff-77d6e2aab53cbf594475ecab6eac3882cd95a1c3d95085833caa58c39cb0a910L4-L11

When usingProxy is true, that would disable mirage server in the initializer

let usingInDev = env === 'development' && !addonConfig.usingProxy;

Right now nothing sets that usingProxy property in the config, so mirage ends up being enabled even when proxies are set

This seems like an unintentional change (wasn't mentioned in 3.0.0 Breaking Changes)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions