temp-fix: After embroider, config was undefined, causing tests to break#2602
Merged
SergeAstapov merged 1 commit intomiragejs:masterfrom Mar 26, 2025
Merged
temp-fix: After embroider, config was undefined, causing tests to break#2602SergeAstapov merged 1 commit intomiragejs:masterfrom
SergeAstapov merged 1 commit intomiragejs:masterfrom
Conversation
|
This is blocking my current upgrade process. Willing to see this PR merged! |
Collaborator
|
thank you @marcemira ! |
|
Should we expect a new version soon? :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
packages/ember-cli-mirage/addon/ember-data.jsfile. The change ensures that theconfigvariable is properly initialized to an empty object if it is undefined.packages/ember-cli-mirage/addon/ember-data.js: Modified the destructuring assignment ofconfigto provide a default empty object, preventing potential errors ifconfigis undefined.Main reference:
cardstack/cardstack#3168