Skip to content

Add support for more than one custom category#351

Merged
nolanlawson merged 2 commits intomissive:masterfrom
Gargron:feature-custom-categories
Dec 21, 2019
Merged

Add support for more than one custom category#351
nolanlawson merged 2 commits intomissive:masterfrom
Gargron:feature-custom-categories

Conversation

@Gargron
Copy link
Copy Markdown

@Gargron Gargron commented Jun 27, 2019

Fix #224

@nolanlawson
Copy link
Copy Markdown

Thanks for the PR! Can you confirm that this isn't a breaking change, and could you add some docs to the README to explain how to use this new feature?

I ran the tests manually and they passed, although a new test wouldn't hurt either. :)

@nolanlawson
Copy link
Copy Markdown

Added some tests to confirm that this isn't a breaking change (if you don't specify customCategory, then the behavior is the same as before), and added a test and storybook for custom category as well as docs.

@nolanlawson
Copy link
Copy Markdown

Storybook with custom categories shown:

Screenshot from 2019-12-21 10-21-31

@nolanlawson nolanlawson merged commit 7a02524 into missive:master Dec 21, 2019
@Gargron Gargron deleted the feature-custom-categories branch December 21, 2019 20:40
@lilong7676
Copy link
Copy Markdown

Thank you. Two questions:
How do I move a custom item to the front?
How to customize the width and height of the emoji icon?

@Gargron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for more than one custom category

3 participants