Merged
Conversation
Don't overwrite planners, fact sources, abilities, and adversary profiles that already exist
14f3d00 to
f60aade
Compare
deacon-mp
previously approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Pull Request Overview
Prevents EMU plugin from overwriting existing data by removing the pre-clean step and adding per-file existence checks before writing or copying.
- Removed directory deletion in hook to avoid wiping existing EMU data
- Added skip-on-exist logic for planners, adversaries, abilities, and sources with debug logs
- Preserved payload decryption and data population flow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| hook.py | Removed rmtree of data subdirectories to stop wholesale deletion of existing EMU data before population. |
| app/emu_svc.py | Added existence checks and skip logic for planner copy and YAML writers for adversaries, abilities, and sources, with debug logs. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
deacon-mp
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Don't overwrite planners, fact sources, abilities, and adversary profiles that already exist
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: